ephraimbuddy commented on a change in pull request #7869: [AIRFLOW-5801] Get GCP credentials from file instead of JSON blob URL: https://github.com/apache/airflow/pull/7869#discussion_r397902054
########## File path: tests/providers/google/cloud/hooks/test_cloud_sql.py ########## @@ -1143,7 +1143,7 @@ def test_cloudsql_database_hook_get_database_hook(self, get_connection): class TestCloudSqlDatabaseHook(unittest.TestCase): - @mock.patch('airflow.contrib.hooks.gcp_sql_hook.CloudSQLDatabaseHook.get_connection') + @mock.patch('airflow.providers.google.cloud.hooks.cloud_sql.CloudSQLDatabaseHook.get_connection') Review comment: Thanks for pointing this out, it will help me to improve. After running the test, I saw deprecation warning and decided to fix it. I know now that I should have created an issue for it or make a better PR title. I really appreciate 🙂 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services