kaxil commented on a change in pull request #6578: [AIRFLOW-5907] Add S3 to MySql Operator URL: https://github.com/apache/airflow/pull/6578#discussion_r398036533
########## File path: tests/providers/mysql/operators/test_s3_to_mysql.py ########## @@ -0,0 +1,82 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import unittest +from unittest.mock import patch + +from airflow import configuration, models +from airflow.providers.mysql.operators.s3_to_mysql import S3ToMySqlTransfer +from airflow.utils import db + + +class TestS3ToMySqlTransfer(unittest.TestCase): + + def setUp(self): + configuration.conf.load_test_config() + + db.merge_conn( + models.Connection( + conn_id='s3_test', + conn_type='s3', + schema='test', + extra='{"aws_access_key_id": "aws_access_key_id", "aws_secret_access_key":' + ' "aws_secret_access_key"}' + ) + ) + db.merge_conn( + models.Connection( + conn_id='mysql_test', + conn_type='mysql', + host='some.host.com', + schema='test_db', + login='user', + password='password' + ) + ) Review comment: Can we remove these connections in tearDown please? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
