[
https://issues.apache.org/jira/browse/AIRFLOW-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068210#comment-17068210
]
ASF subversion and git services commented on AIRFLOW-4453:
----------------------------------------------------------
Commit 1605f1def43c86f84a1c1a7e7732d46bb0e1814a in airflow's branch
refs/heads/v1-10-test from yuqian90
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=1605f1d ]
[AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation
(#7464)
The documentation for the `none_failed` trigger rule
(https://airflow.apache.org/docs/stable/concepts.html#trigger-rules)
describes its behavior as "all parents have not failed (`failed` or
`upstream_failed`) i.e. all parents have succeeded or been skipped."
With that definition in mind, there is no reason that the check for
`none_failed` should ever have to check for skipped upstream tasks or
set the current task to `skipped`. The current behavior causes the rule
to skip if all upstream tasks have skipped, which is more than a little
confusing. This fixes the behavior to be consistent with the documentation.
Co-authored-by: root <[email protected]>
(cherry picked from commit f0c65e32103fa0fe91a4890d75ba31a89aa226e7)
> none_failed trigger rule cascading skipped state to downstream tasks
> --------------------------------------------------------------------
>
> Key: AIRFLOW-4453
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4453
> Project: Apache Airflow
> Issue Type: Bug
> Components: DAG, scheduler
> Affects Versions: 1.10.3, 1.10.4, 1.10.5, 1.10.6, 1.10.7
> Reporter: Dmytro Kulyk
> Assignee: Kaxil Naik
> Priority: Major
> Labels: skipped
> Fix For: 1.10.5, 1.10.10
>
> Attachments: 3_step.png, cube_update.py,
> image-2019-05-02-18-11-28-307.png, simple_skip.png
>
>
> Task with trigger_rule = 'none_failed' cascading *skipped *status to
> downstream task
> * task have multiple upstream tasks
> * trigger_rule set to 'none_failed'
> * some of upstream tasks can be skipped due to *latest only*
> Basing on documentation this shouldn't happen
> !image-2019-05-02-18-11-28-307.png|width=655,height=372!
> DAG attached
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
