jmcarp commented on a change in pull request #6379: [AIRFLOW-5708] Optionally
check task pools when parsing dags.
URL: https://github.com/apache/airflow/pull/6379#discussion_r399025328
##########
File path: airflow/models/dagbag.py
##########
@@ -178,7 +180,7 @@ def get_dag(self, dag_id):
del self.dags[dag_id]
return self.dags.get(dag_id)
- def process_file(self, filepath, only_if_updated=True, safe_mode=True):
+ def process_file(self, filepath, only_if_updated=True, safe_mode=True,
check_pools=False, pools=None):
Review comment:
I think it's better to fail fast. If my dag is invalid, I want to know about
it right away, even if it's paused. We already check for import errors and dag
cycles in `DagBag.process_file`, so I think it makes sense to check for missing
pools here too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
