potiuk commented on a change in pull request #7832: [WIP] Add production image
support
URL: https://github.com/apache/airflow/pull/7832#discussion_r399168374
##########
File path: .travis.yml
##########
@@ -41,24 +41,24 @@ jobs:
stage: pre-test
script: ./scripts/ci/ci_run_all_static_checks.sh
env: >-
- PYTHON_VERSION=3.6
+ PYTHON_MAJOR_MINOR_VERSION=3.6
Review comment:
I already explained it before - because PYTHON_VERSION is set to 3.6.9 in
the base Python images and it causes a lot of confusion as depending on the
script sometimes you can get PYTHON_VERSION = 3.6.9 and sometimes 3.6.
MAJOR_MINOR_VERSION is pretty straightforward IMHO. Do you have any other
proposal. The requirements for the name are:
1) can't be PYTHON_VERSION (already set by the base image)
2) Has to correctly reflect 3.9 being MAJOR.MINOR version of python
3) Cannot have "." (environment variable can't have dots).
What is your proposal for the name of this variable please ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
