feluelle commented on a change in pull request #7903: Add conn_name and
get_connection to dbapi_hook
URL: https://github.com/apache/airflow/pull/7903#discussion_r400904172
##########
File path: airflow/hooks/dbapi_hook.py
##########
@@ -62,15 +63,32 @@ def __init__(self, *args, **kwargs):
raise AirflowException("conn_name_attr is not defined")
elif len(args) == 1:
setattr(self, self.conn_name_attr, args[0])
- elif self.conn_name_attr not in kwargs:
- setattr(self, self.conn_name_attr, self.default_conn_name)
else:
- setattr(self, self.conn_name_attr, kwargs[self.conn_name_attr])
+ setattr(self, self.conn_name_attr, kwargs.get(self.conn_name_attr,
self.default_conn_name))
+
+ @property
+ def conn_name(self) -> str:
+ """
+ Get conn_name to avoid pylint no-member in subclass
+ """
+ return getattr(self, self.conn_name_attr)
+
+ def get_connection(self, conn_id: Optional[str] = None) -> Connection:
+ """
+ Get connection from conn_id, if conn_id is None,
+ will get from `getattr(self, self.conn_name_attr)`
+
+ :param conn_id: connection id
+ :type conn_id: Optional[str]
+ :return: Connection
+ """
+ conn_name = conn_id if conn_id is not None else self.conn_name
Review comment:
```suggestion
conn_name = conn_id or self.conn_name
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
