kaxil commented on a change in pull request #8024: [AIRFLOW-4529] Add support for Azure Batch Service URL: https://github.com/apache/airflow/pull/8024#discussion_r401520091
########## File path: airflow/providers/microsoft/azure/hooks/azure_batch.py ########## @@ -0,0 +1,348 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +import time +from datetime import timedelta +from typing import Optional + +from azure.batch import BatchServiceClient, batch_auth, models as batch_models + +from airflow.exceptions import AirflowException +from airflow.hooks.base_hook import BaseHook +from airflow.utils import timezone + + +class AzureBatchHook(BaseHook): + """ + Hook for Azure Batch APIs + """ + + def __init__(self, azure_batch_conn_id='azure_batch_default'): + super().__init__() + self.conn_id = azure_batch_conn_id + self.connection = self.get_conn() Review comment: I would say we can remove `self.connection` from here and use the get_conn or get_connection method in the `execute` method of Operator ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
