ryanahamilton commented on a change in pull request #8046: [AIRFLOW-7048] Allow
user to convert timezone in UI
URL: https://github.com/apache/airflow/pull/8046#discussion_r401912024
##########
File path: airflow/www/templates/appbuilder/navbar_right.html
##########
@@ -46,8 +46,22 @@
</li>
{% endmacro %}
-<!-- clock -->
-<li><a id="clock"></a></li>
+{# clock and timezone menu #}
+<li class="dropdown">
+ <a class="dropdown-toggle" data-toggle="dropdown" style="display:none">
+ <span id="clock"></span>
+ <b class="caret"></b>
+ </a>
+ <ul class="dropdown-menu" id="timezone-menu">
+ <li><a id="timezone-utc" data-timezone="UTC">UTC</a></li>
+ <li><a id="timezone-local">Local</a></li>
+ <li style="display: none"><a id="timezone-manual"
data-timezone=""></a></li>
+ <hr>
+ <li id="timezone-other"><span>Other</span>
+ <input placeholder="Timezone name" autocomplete="off">
Review comment:
Related to the previous CSS suggestion—changing this to a `<label>` element:
```suggestion
<li id="timezone-other">
<label for="timezone-other-input"
class="timezone-other-label">Other</label>
<input type="text" id="timezone-other-input" placeholder="Timezone
name" autocomplete="off">
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
