[
https://issues.apache.org/jira/browse/AIRFLOW-5500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074145#comment-17074145
]
ASF GitHub Bot commented on AIRFLOW-5500:
-----------------------------------------
cBournhonesque commented on pull request #8081: [AIRFLOW-5500] Fix the
trigger_dag api in the case of nested subdags
URL: https://github.com/apache/airflow/pull/8081
Like the jira issue states
(https://issues.apache.org/jira/browse/AIRFLOW-5500), the experimental api is
broken when one tries to trigger a dag that contains nested subdags.
The reason for this is that calling `dag.subdags` returns a list of ALL the
subdags for the dag (even the nested ones), instead of the direct child subdags.
My fix directly changes the trigger_dag.py, but a better solution is
probably to make `dag.subdags` return only the child subdags. I didn't know if
the current behaviour was chosen for a specific reason so I decided to just
change the experimental api.
---
Make sure to mark the boxes below before creating PR: [x]
- [X] Description above provides context of the change
- [X] Unit tests coverage for changes (not needed for documentation changes)
- [X] Commits follow "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Bug in trigger api endpoint
> ----------------------------
>
> Key: AIRFLOW-5500
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5500
> Project: Apache Airflow
> Issue Type: Bug
> Components: api
> Affects Versions: 1.10.1
> Reporter: Deavarajegowda M T
> Priority: Critical
> Attachments: 3level.py
>
>
> Unable to trigger workflow with nested sub dags, getting following error:
> sqlalchemy.exc.IntegrityError: (psycopg2.IntegrityError) duplicate key value
> (dag_id,execution_date)=('dummy.task1.task_level1.task_level2','2019-09-10
> 13:00:27+00:00') violates unique constraint
> "dag_run_dag_id_execution_date_key"
> trigger_dag for nested sub_dags is called twice.
>
> fix:
> in airflow/api/common/experimental/trigger_dag.py -
> while populating subdags for a dag, each subdag's subdags is also populated
> to main dag.
> So no need to repopulate subdags for each subdag separately.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
