[
https://issues.apache.org/jira/browse/AIRFLOW-6780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075567#comment-17075567
]
ASF GitHub Bot commented on AIRFLOW-6780:
-----------------------------------------
brandonwillard commented on pull request #8146: [AIRFLOW-6780] Add option to
use args instead of command in K8s pod spec
URL: https://github.com/apache/airflow/pull/8146
This PR adds a config option, `kubernetes.worker_pod_uses_args`, that is
passed to `PodGenerator.construct_pod` in order to decide whether or not the
Kubernetes `args` field is used instead of `command` in the worker pod specs.
This PR is replacing #7405 (moved to my personal fork).
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Use args Instead of command in Kubernetes Executor Worker Pods
> --------------------------------------------------------------
>
> Key: AIRFLOW-6780
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6780
> Project: Apache Airflow
> Issue Type: Bug
> Components: executor-kubernetes
> Affects Versions: 1.10.7, 1.10.8, 1.10.9
> Reporter: Brandon Willard
> Assignee: Daniel Imberman
> Priority: Blocker
>
> The worker pods created by the Kubernetes Executor are hard-coded to use [the
> {{command}} field instead of
> {{args}}|[https://kubernetes.io/docs/tasks/inject-data-application/define-command-argument-container/#notes]!|https://kubernetes.io/docs/tasks/inject-data-application/define-command-argument-container/#notes].
> The result is a worker pod that ignores its image's entry-point and
> prevents the standard means of executing container preparation code --- among
> other things.
> This --- alongside the issues stated in
> [AIRFLOW-6778|https://issues.apache.org/jira/browse/AIRFLOW-6778] and
> [AIRFLOW-3126|https://issues.apache.org/jira/browse/AIRFLOW-3126] --- renders
> worker nodes virtually incompatible with a dynamic, shared DAGs volume
> (unless dependencies are installed in the image and never change).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
