turbaszek commented on issue #8145: Drop redundant project id null checks.
URL: https://github.com/apache/airflow/pull/8145#issuecomment-609463052
 
 
   I have mixed feelings... First, I am not a big fan of adding more and more 
custom plugins (especially to solve problems that should be solved on language 
level #static_types_fan) . Especially to solve problems that I am not even sure 
are real problems. Since we have the `if` clause I even started to like the 
"explicit" information about `project_id` ("at this point, it will be provided 
by decorator").  
   
   On the other hand, this change does no harm. It makes our codebase bigger 
and adds next moving part to it. So, I am not sure.
   
   I am curious about what others think? @mik-laj @kaxil @ashb @potiuk 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to