mik-laj commented on a change in pull request #8008: Custom Facebook Ads 
Operator
URL: https://github.com/apache/airflow/pull/8008#discussion_r404424465
 
 

 ##########
 File path: airflow/providers/facebook/ads/operators/ads.py
 ##########
 @@ -0,0 +1,119 @@
+#
 
 Review comment:
   The file name should be called facebook_ads_to_gcs and should be in the 
`airflow/providers/google/cloud/operators` package. Transfer operators should 
be grouped by destination.  Unless the source is a large cloud provider.  Then 
it should be in cloud provider package. As long as the source and destination 
is a cloud provider. In this case, it's by destination.
   More information: 
https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to