mik-laj edited a comment on issue #8163: Google `Credentials` object has not 
attribute `with_subject`
URL: https://github.com/apache/airflow/issues/8163#issuecomment-610372050
 
 
   Yes. We should do it. Can you deal with this? I think that if someone passes 
the delegate_to parameter and the current credentials object does not have the 
with_subject attribute, an exception should be raised: "The current 
authentication method does not support account impersonate. Please use 
service-account for authorization.". 
   The corresponding code is here:
   
https://github.com/apache/airflow/blob/beef6c2/airflow/providers/google/cloud/utils/credentials_provider.py#L243-L244
   Tests: 
https://github.com/apache/airflow/blob/8a02402/tests/providers/google/common/hooks/test_base_google.py#L337
   
   Contributor guide: 
https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst
   Development environment: 
https://github.com/apache/airflow/blob/master/BREEZE.rst
   
   The community is waiting for your contribution 🐈 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to