ashb commented on a change in pull request #8227: Add run_type to DagRun
URL: https://github.com/apache/airflow/pull/8227#discussion_r406122863
##########
File path: airflow/api/common/experimental/mark_tasks.py
##########
@@ -48,11 +48,11 @@ def _create_dagruns(dag, execution_dates, state, run_type):
for date in dates_to_create:
dag_run = dag.create_dagrun(
- run_id=f"{run_type}__{date.isoformat()}",
Review comment:
I think run_type should be non-null in the db, yes. So perhaps make run_type
required, but run_id can be overridden.
We could detect run_type based on run_id, it would make it easier for anyone
to upgrade, sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
