mik-laj commented on a change in pull request #8213: Fix issue #8163 where gcp
auth fails
URL: https://github.com/apache/airflow/pull/8213#discussion_r406754526
##########
File path: airflow/providers/google/cloud/utils/credentials_provider.py
##########
@@ -241,7 +241,14 @@ def get_credentials_and_project_id(
project_id = credentials.project_id
if delegate_to:
- credentials = credentials.with_subject(delegate_to)
+ if hasattr(credentials, 'with_subject'):
Review comment:
```python
from google.auth import compute_engine
```
```python
@mock.patch('google.auth.default')
def
test_get_credentials_and_project_id_with_default_auth_and_unsupported_delegate(self,
mock_auth_default):
mock_credentials = mock.MagicMock(spec=compute_engine.Credentials)
mock_auth_default.return_value = (mock_credentials,
self.test_project_id)
with self.assertRaisesRegex(AirflowException, re.escape(
"The `delegate_to` parameter cannot be used here as the current
authentication method does not "
"support account impersonate. Please use service-account for
authorization."
)):
get_credentials_and_project_id(delegate_to="USER")
```
Can you check it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
