turbaszek commented on a change in pull request #8377: Use python client in BQ
hook create_empty_table method
URL: https://github.com/apache/airflow/pull/8377#discussion_r409047406
##########
File path: airflow/providers/google/cloud/hooks/bigquery.py
##########
@@ -227,45 +236,43 @@ def create_empty_table(self, # pylint:
disable=too-many-arguments
:type num_retries: int
:return: None
"""
- service = self.get_service()
-
- project_id = project_id if project_id is not None else self.project_id
+ if num_retries:
+ warnings.warn("Parameter `num_retries` is deprecated",
DeprecationWarning)
- table_resource = {
+ _table_resource: Dict[str, Any] = {
Review comment:
The reason is this line:
```
table_resource = table_resource or _table_resource
```
I wanted to avoid adding a big if clause and building this simple dictionray
everytime is not a big performance issue I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
