potiuk commented on a change in pull request #8393: Bring back CI optimisations
URL: https://github.com/apache/airflow/pull/8393#discussion_r409471211
##########
File path: scripts/ci/_utils.sh
##########
@@ -134,6 +134,14 @@ function initialize_common_environment {
"--env" "PYTHONDONTWRITEBYTECODE" \
)
fi
+
+ if [[ ${CI:=} == "true" ]]; then
+ CI_CODECOV_ENV="$(bash <(curl -s https://codecov.io/env))"
Review comment:
That's standard way of using Codecov when running codecov inside docker:
https://docs.codecov.io/docs/testing-with-docker
It detects automatically which CI codecov it is running on (it supports
pretty much all of the CIs ) and it return appropriate "-e ENV" sequence to
pass the right variables to inside docker.
This is needed because codecov puts together code coverage from multiple
jobs running in different jobs/ machines so it needs to have a way to know that
they all belong to the same build. And codecove does it via CI-specific
environment variables.
Previously we passed the necessary TRAVIS_ * variables in base.yaml but the
way it is done now it will work well for any CI this script will run on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
