eladkal commented on issue #7858: ShortCircuitOperator Ignoring Trigger Rules 
for Downstream Task and Skipping all Tasks
URL: https://github.com/apache/airflow/issues/7858#issuecomment-615863490
 
 
   When the callable of `ShortCircuitOperator` is evaluated to `False` it 
short-circuits the entire downstream branch. This means that all downstream 
tasks are set to `SKIP` immediately. This is done by calling `skip` method of 
`SkipMixin`.
   The `ShortCircuitOperator` is more for the usage of "Stop here. don't 
continue no matter what."
   
   The docs seems to be written by the spirit of `BranchPythonOperator` where 
it uses `skip_all_except` method of `SkipMixin`. It's not quite the same 
because it checks for dependency between tasks rather than trigger rules but at 
it uses a less violent approach.
   
   I'm not sure if this this is a bug in the `ShortCircuitOperator`. I for once 
have workflows that need the functionality exactly as it is now so I think this 
is more case of wrong documentation issue rather than a bug.
   
   On the other hand maybe the `ShortCircuitOperator` can be enhanced to have 
two modes: `hard` & `soft`. Where `hard` is the same behavior as now while 
`soft` will check if SKIP should cascade further.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to