RosterIn commented on a change in pull request #7739: [AIRFLOW-7044] Add
host_key option to SSH connection extras
URL: https://github.com/apache/airflow/pull/7739#discussion_r410988476
##########
File path: airflow/providers/ssh/hooks/ssh.py
##########
@@ -275,3 +281,36 @@ def create_tunnel(
category=DeprecationWarning)
return self.get_tunnel(remote_port, remote_host, local_port)
+
+ @staticmethod
+ def _add_new_record_to_known_hosts(record, file):
+ file.write(''.join([record, '\n']))
+
+ @staticmethod
+ def add_host_to_known_hosts(host, key_type, host_key):
+ """This adds a specified remote_host public key to the known_hosts
+ in order to prevent man-in-the-middle attacks."""
+ # The .ssh hidden directory is required and not present on all airflow
deployments
+ known_hosts_file_ref = SSHHook._create_known_hosts()
Review comment:
Is there assumption here that this method always successful?
Can there be cases where it throws exception that isn't handled?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
