[ 
https://issues.apache.org/jira/browse/AIRFLOW-5262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17087349#comment-17087349
 ] 

ASF GitHub Bot commented on AIRFLOW-5262:
-----------------------------------------

curiousjazz77 opened a new pull request #8466:
URL: https://github.com/apache/airflow/pull/8466


   ### Jira
   - My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW-5262) 
   
   ### Description
   
   - This change will help expedite log investigation in third party logging 
services, making the dag's name visible in the top-level exception message.
   
   ### Tests
   
   - My PR adds the following unit tests __OR__ does not need testing for this 
extremely good reason: does not need testing
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
   Continuation of this old, closed PR: 
https://github.com/apache/airflow/pull/5919
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Update timeout exception to include dag name
> --------------------------------------------
>
>                 Key: AIRFLOW-5262
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5262
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: DagRun
>    Affects Versions: 1.10.4
>            Reporter: Jasmine Omeke
>            Assignee: Jasmine Omeke
>            Priority: Minor
>
> This exception 
> ([https://github.com/apache/airflow/blob/f06ae8fbe9a5c786f0299872abc85d9960b05886/airflow/sensors/base_sensor_operator.py#L114-L116])
>  could be made clearer for cursory log investigation (especially in third 
> party paging systems) by including the DAG name with this timeout error 
> message.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to