khyurri commented on issue #8284:
URL: https://github.com/apache/airflow/issues/8284#issuecomment-616776793


   ```
   def __init__(
           self,
           body: dict,
           aws_conn_id: str = 'aws_default',
           gcp_conn_id: str = 'google_cloud_default',
           api_version: str = 'v1',
           *args,
           **kwargs
       )
   ```
   
   In such a method, it’s rather difficult to nicely add support for something 
other than `aws_conn_id`, while maintaining backward compatibility.
   
   I see 2 options
   
   1. Add the `msa_conn_id` parameter befor `*args`. In this case, if 
`msa_conn_id` is passed, use it, otherwise `aws_conn_id`. `msa_conn_id` cannot 
be set to the default value.
   
   2. Divide CloudDataTransferServiceCreateJobOperator into 2 operators: for 
AWS and for Azure. This leave for compatibility for AWS, may declare it obsolete
   
   Which option is more acceptable?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to