milton0825 commented on a change in pull request #7650: URL: https://github.com/apache/airflow/pull/7650#discussion_r412652482
########## File path: scripts/perf/perf_kit/python.py ########## @@ -0,0 +1,108 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import contextlib +import cProfile +import datetime +import io +import os +import pstats +import signal + +PYSPY_OUTPUT = os.environ.get("PYSPY_OUTPUT", "/files/pyspy/") + + [email protected] +def pyspy(): + """ + This decorator provide deterministic profiling. It generate and save flame graph to file. It uses``pyspy`` + internally. + + Running py-spy inside of a docker container will also usually bring up a permissions denied error + even when running as root. + + This error is caused by docker restricting the process_vm_readv system call we are using. This can be Review comment: Is it possible to surface the solution as part of the error message to user in case we run into the permission error? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
