ryanahamilton commented on a change in pull request #8269:
URL: https://github.com/apache/airflow/pull/8269#discussion_r413044104
##########
File path: airflow/www/templates/airflow/dags.html
##########
@@ -554,5 +552,33 @@ <h2>DAGs</h2>
$(".loading-task-stats").remove();
$(".loading-dag-stats").remove();
}
+
+ function showSvgTooltip(text, offsetTop, offsetLeft) {
+ var tip = $('#svg-tooltip');
+ tip.children('.tooltip-inner').text(text);
+ var centeringOffset = tip.width() / 2;
+ tip.css({
+ "display": "block",
+ "left": offsetLeft + 12.5 - centeringOffset + 'px',// 12.5 == half of
circle width
Review comment:
I simplified the function argument similar to your first suggestion.
Your IE comment caused some confusion for me—I was thinking that I had used
the unsupported `getboundingclientrect` properties, though that wasn't the
fact. I did end up confirming that this works in IE Edge. I also tested in an
IE11 instance, but the UI failed to operate properly. Those are either much
larger compatibility issues or due to unresponsiveness of the VirtualBox
instance I was testing in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
