CodingJonas commented on a change in pull request #8533:
URL: https://github.com/apache/airflow/pull/8533#discussion_r415755244
##########
File path: airflow/providers/docker/operators/docker.py
##########
@@ -289,6 +279,18 @@ def execute(self, context):
return self._run_image()
+ def _set_cli(self):
+ tls_config = self.__get_tls_config()
+
+ if self.docker_conn_id:
+ self.cli = self.get_hook().get_conn()
+ else:
+ self.cli = APIClient(
Review comment:
You are right, this is nicer :) I updated it in another commit. If
everything is fine I would squash the two commits into one before merging.
##########
File path: airflow/providers/docker/operators/docker.py
##########
@@ -289,6 +279,18 @@ def execute(self, context):
return self._run_image()
+ def _set_cli(self):
+ tls_config = self.__get_tls_config()
+
+ if self.docker_conn_id:
+ self.cli = self.get_hook().get_conn()
+ else:
+ self.cli = APIClient(
Review comment:
You are right, this is nicer :) I updated it in a second commit. If
everything is fine I would squash the two commits into one before merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
