turbaszek commented on a change in pull request #8591:
URL: https://github.com/apache/airflow/pull/8591#discussion_r415973240
##########
File path: airflow/providers/http/example_dags/example_http.py
##########
@@ -42,6 +42,7 @@
dag.doc_md = __doc__
# t1, t2 and t3 are examples of tasks created by instantiating operators
+# [START howto_operator_http_t1]
t1 = SimpleHttpOperator(
task_id='post_op',
Review comment:
```suggestion
post_op = SimpleHttpOperator(
task_id='post_op',
```
I like it when task instance and task_id are inline.WDYT?
##########
File path: tests/providers/http/operators/test_http_system.py
##########
@@ -0,0 +1,35 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import os
+
+import pytest
+
+from tests.test_utils import AIRFLOW_MAIN_FOLDER
+from tests.test_utils.system_tests_class import SystemTest
+
+HTTP_DAG_FOLDER = os.path.join(
+ AIRFLOW_MAIN_FOLDER, "airflow", "providers", "http", "example_dags"
+)
+
+
[email protected]("mysql", "postgres")
[email protected]("http")
Review comment:
I'm wondering if we should use more generic system type like "core" or
something. WDYT? @potiuk ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
