jeffolsi commented on a change in pull request #8429:
URL: https://github.com/apache/airflow/pull/8429#discussion_r416119369
##########
File path: airflow/providers/http/hooks/http.py
##########
@@ -66,7 +75,7 @@ def get_conn(self, headers=None):
if conn.port:
self.base_url = self.base_url + ":" + str(conn.port)
if conn.login:
- session.auth = (conn.login, conn.password)
+ session.auth = self.auth_type(conn.login, conn.password)
Review comment:
the change make sense to me since it uses request package so it can work
with custom auth
https://2.python-requests.org/en/master/user/advanced/#custom-authentication
provide the
the auth_type in this context is auth object passed in the operator
constructor
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
