[
https://issues.apache.org/jira/browse/AIRFLOW-5156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093909#comment-17093909
]
ASF GitHub Bot commented on AIRFLOW-5156:
-----------------------------------------
mik-laj commented on a change in pull request #8429:
URL: https://github.com/apache/airflow/pull/8429#discussion_r416123217
##########
File path: airflow/providers/http/hooks/http.py
##########
@@ -66,7 +75,7 @@ def get_conn(self, headers=None):
if conn.port:
self.base_url = self.base_url + ":" + str(conn.port)
if conn.login:
- session.auth = (conn.login, conn.password)
+ session.auth = self.auth_type(conn.login, conn.password)
Review comment:
https://requests.readthedocs.io/en/master/user/authentication/
Is it used with other methods?
I think it would be better if the user passed the auth object, not just the
auth_type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add other authentication mechanisms to HttpHook
> -----------------------------------------------
>
> Key: AIRFLOW-5156
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5156
> Project: Apache Airflow
> Issue Type: Improvement
> Components: hooks
> Affects Versions: 1.10.4
> Reporter: Joshua Kornblum
> Assignee: Rohit S S
> Priority: Minor
>
> It looks like the only supported authentication for HttpHooks is basic auth.
> The hook code shows
> {quote}_if conn.login:_
> _session.auth = (conn.login, conn.password)_
> {quote}
> requests library supports any auth that inherits AuthBase – in my scenario we
> need ntlmauth for API on IIS server.
> [https://2.python-requests.org/en/master/user/advanced/#custom-authentication]
> I would suggest option to pass auth object in constructor then add to if/else
> control flow like
> {quote}_if self.auth is not None:_
> _session.auth = self.auth_
> _elif conn.login:_
> _session.auth = (conn.login, conn.password)_
> {quote}
> One would have to fetch the connection themselves and then fill out auth and
> then pass that to hook which is flexible although a little awkard.
> {quote}api_conn = BaseHook().get_connection('my_api')
> auth = HttpNtlmAuth(api_conn.login, api_conn.password)
> HttpSensor(task_id='sensing', auth=auth, ....)
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
