mik-laj commented on a change in pull request #8531:
URL: https://github.com/apache/airflow/pull/8531#discussion_r416175888
##########
File path: tests/providers/google/cloud/hooks/test_dataflow.py
##########
@@ -52,32 +54,32 @@
'stagingLocation': 'gs://test/staging',
'labels': {'foo': 'bar'}
}
-DATAFLOW_VARIABLES_TEMPLATE = {
- 'project': 'test',
- 'tempLocation': 'gs://test/temp',
- 'zone': 'us-central1-f'
-}
RUNTIME_ENV = {
- 'tempLocation': 'gs://test/temp',
- 'zone': 'us-central1-f',
- 'numWorkers': 2,
- 'maxWorkers': 10,
- 'serviceAccountEmail': '[email protected]',
- 'machineType': 'n1-standard-1',
'additionalExperiments': ['exp_flag1', 'exp_flag2'],
- 'network': 'default',
- 'subnetwork': 'regions/REGION/subnetworks/SUBNETWORK',
'additionalUserLabels': {
'name': 'wrench',
'mass': '1.3kg',
'count': '3'
- }
+ },
+ 'bypassTempDirValidation': {},
+ 'ipConfiguration': 'WORKER_IP_PRIVATE',
+ 'kmsKeyName': (
+
'projects/TEST_PROJECT_ID/locations/TEST_LOCATIONS/keyRings/TEST_KEYRING/cryptoKeys/TEST_CRYPTOKEYS'
+ ),
+ 'maxWorkers': 10,
+ 'network': 'default',
+ 'numWorkers': 2,
+ 'serviceAccountEmail': '[email protected]',
+ 'subnetwork': 'regions/REGION/subnetworks/SUBNETWORK',
+ 'tempLocation': 'gs://test/temp',
+ 'workerRegion': "test-region",
+ 'workerZone': 'test-zone',
+ 'zone': 'us-central1-f',
+ 'machineType': 'n1-standard-1',
Review comment:
IP Configuration is also tested on line 65.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
