[
https://issues.apache.org/jira/browse/AIRFLOW-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095054#comment-17095054
]
ASF GitHub Bot commented on AIRFLOW-4734:
-----------------------------------------
oxymor0n opened a new pull request #8625:
URL: https://github.com/apache/airflow/pull/8625
`PostgresHook`'s parent class, `DbApiHook`, implements upsert in its
`insert_rows()` method with the `replace=True` flag. However, the underlying
generated SQL is specific to MySQL's "REPLACE INTO" syntax and is not
applicable to Postgres.
I'd like to override this method in PostgresHook to implement the "INSERT
... ON CONFLICT DO UPDATE" syntax (new since Postgres 9.5)
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Upsert functionality for PostgresHook.insert_rows()
> ---------------------------------------------------
>
> Key: AIRFLOW-4734
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4734
> Project: Apache Airflow
> Issue Type: Improvement
> Components: hooks
> Affects Versions: 1.10.3
> Reporter: William Tran
> Assignee: William Tran
> Priority: Minor
> Labels: features
> Fix For: 2.0.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> PostgresHook's parent class, DbApiHook, implements upsert in its
> insert_rows() method with the replace=True flag. However, the underlying
> generated SQL is specific to MySQL's "REPLACE INTO" syntax and is not
> applicable to Postgres.
> I'd like to override this method in PostgresHook to implement the "INSERT ...
> ON CONFLICT DO UPDATE" syntax (new since Postgres 9.5)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
