[ 
https://issues.apache.org/jira/browse/AIRFLOW-5906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096281#comment-17096281
 ] 

ASF GitHub Bot commented on AIRFLOW-5906:
-----------------------------------------

koszti opened a new pull request #8642:
URL: https://github.com/apache/airflow/pull/8642


   To use Snowflake with SSO, Okta, ADFS or any other SAML 2.0 compliant 
identify provider we need to pass the `authenticator=externalbrowser` extra 
parameter to the snowflake connection string. Currently the `authenticator` 
parameter not extracted from the connection extras JSON and not possible to use 
Airflow and Snowflake with SAML/SSO
   
   This PR extracts the `authenticator` parameter from the connection "extra"s 
JSON and passing it to the snowflake uri. This allows to use Airflow and 
Snowflake configured with SAML/SSO. 
   
   Example airflow connection config:
   ```
   Conn Id: <CONNECTION_ID>
   Conn Type: Snowflake
   Host: <YOUR_SNOWFLAKE_HOSTNAME>
   Schema: <YOUR_SNOWFLAKE_SCHEMA>
   Login: <YOUR_SNOWFLAKE_USERNAME>
   Password: <YOUR_SNOWFLAKE_PASSWORD>
   Extra: {
           "account": <YOUR_SNOWFLAKE_ACCOUNT_NAME>,
           "warehouse": <YOUR_SNOWFLAKE_WAREHOUSE_NAME>,
            "database": <YOUR_SNOWFLAKE_DB_NAME>,
            "region": <YOUR_SNOWFLAKE_HOSTED_REGION>,
            "authentication": "externalbrowser"
       }
   ```
   
   Related snowflake documentation with the valid authentication strings: 
[Snowflake Python: Connecting using Federated 
Authentication](https://docs.snowflake.com/en/user-guide/python-connector-example.html#connecting-using-federated-authentication)
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Target Github ISSUE in description if exists
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Add authenticator parameter to snowflake_hook
> ---------------------------------------------
>
>                 Key: AIRFLOW-5906
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5906
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: authentication
>    Affects Versions: 1.10.6
>            Reporter: Salvador RIbolzi
>            Assignee: Salvador RIbolzi
>            Priority: Major
>              Labels: features
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> We are currently migrating to using SAML to log in to Snowflake, to do so a 
> parameter `authenticator=externalbrowser` must be set. Currently the hook for 
> snowflake does not check for that parameter.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to