[
https://issues.apache.org/jira/browse/AIRFLOW-7031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096612#comment-17096612
]
ASF GitHub Bot commented on AIRFLOW-7031:
-----------------------------------------
NBardelot commented on pull request #7682:
URL: https://github.com/apache/airflow/pull/7682#issuecomment-621906955
> I kindly ask you to verify the created PR
Yep I wrote the comment before seeing that going from master to v1-10-stable
was a mess. I fixed it. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Airflow WinRM endpoint is hardcoded to HTTP
> -------------------------------------------
>
> Key: AIRFLOW-7031
> URL: https://issues.apache.org/jira/browse/AIRFLOW-7031
> Project: Apache Airflow
> Issue Type: Bug
> Components: hooks
> Affects Versions: 1.10.9
> Reporter: Noël BARDELOT
> Priority: Minor
>
> In airflow/providers/microsoft/winrm/hooks/winrm.py the following code is
> hardcoded to use 'http' even when the service is set to use 'https':
> {code}
> # If endpoint is not set, then build a standard wsman endpoint from host and
> port.
> if not self.endpoint:
> self.endpoint = 'http://{0}:{1}/wsman'.format(self.remote_host,
> self.remote_port)
> {code}
> Workaround: configure the 'enpoint' setting manually in the extra
> configuration of the connection.
> Correction: make the protocol configurable, depending on the value of the
> 'service' configuration (if 'HTTP' then 'http://' should be used, and if
> 'HTTPS' then 'https://' should be used).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
