kaxil commented on a change in pull request #8652: URL: https://github.com/apache/airflow/pull/8652#discussion_r419009100
########## File path: tests/models/test_xcom_arg.py ########## @@ -0,0 +1,146 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from datetime import datetime, timedelta + +from airflow import DAG +from airflow.models.xcom_arg import XComArg +from airflow.operators.bash import BashOperator +from airflow.operators.python import PythonOperator + +DEFAULT_ARGS = { + "owner": "test", + "depends_on_past": True, + "start_date": datetime.today(), + "retries": 1, + "retry_delay": timedelta(minutes=1), +} + +VALUE = 42 + + +def assert_is_value(num: int): + assert num == VALUE + + +def build_python_op(): + def f(task_id): + return f"OP:{task_id}" + + with DAG(dag_id="test_xcom_dag", default_args=DEFAULT_ARGS): + operator = PythonOperator( + python_callable=f, + task_id="test_xcom_op", + do_xcom_push=True, + ) + return operator + + +class TestXComArgBuild: + def test_xcom_ctor(self): + python_op = build_python_op() + actual = XComArg(python_op, "test_key") + assert actual + assert actual.operator == python_op + assert actual.key == "test_key" + assert actual == actual # pylint: disable=comparison-with-itself + assert str(actual) + + def test_xcom_key_is_empty_str(self): + python_op = build_python_op() + actual = XComArg(python_op, key="") + assert actual.key == "" + assert str(actual) == "task_instance.xcom_pull(task_ids='test_xcom_op', " \ + "dag_id='test_xcom_dag', key='')" + + def test_set_downstream(self): + with DAG("test_set_downstream", default_args=DEFAULT_ARGS): + op_a = BashOperator(task_id="a", bash_command="echo a") + op_b = BashOperator(task_id="b", bash_command="echo b") + bash_op = BashOperator(task_id="c", bash_command="echo c") + xcom_args_a = XComArg(op_a) + xcom_args_b = XComArg(op_b) + + xcom_args_a >> xcom_args_b >> bash_op + + assert len(op_a.downstream_list) == 2 + assert op_b in op_a.downstream_list + assert bash_op in op_a.downstream_list + + def test_set_upstream(self): + with DAG("test_set_upstream", default_args=DEFAULT_ARGS): + op_a = BashOperator(task_id="a", bash_command="echo a") + op_b = BashOperator(task_id="b", bash_command="echo b") + bash_op = BashOperator(task_id="c", bash_command="echo c") + xcom_args_a = XComArg(op_a) + xcom_args_b = XComArg(op_b) + + xcom_args_a << xcom_args_b << bash_op + + assert len(op_a.upstream_list) == 2 + assert op_b in op_a.upstream_list + assert bash_op in op_a.upstream_list + + def test_xcom_arg_property_of_base_operator(self): + with DAG("test_xcom_arg_property_of_base_operator", default_args=DEFAULT_ARGS): + op_a = BashOperator(task_id="a", bash_command="echo a") + + assert op_a.output == XComArg(op_a) Review comment: Can we assert the real output value too? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
