XD-DENG opened a new pull request #8685:
URL: https://github.com/apache/airflow/pull/8685
Currently in `master` and `1.10.10`, connection add/edit UI pages are not
working correctly.
## Current Connection Adding for Spark ('Spark' in not available):
## Current Connection Editing for Spark:
You can easily reproduce this by trying to edit default connection
`spark_default`.
## Root-cause
The root-cause is that "spark" is not listed in `models.Connection._types`.
So when `www/forms.py` tries to produce the UI, "spark" is not available and it
always tried to "fall back" to the option list whose first entry is "Docker"
(this is why we see "Docker Registry" when we edit "spark_default").
In addition, we should hide irrelevant entries for spark connections
("schema", "login", and "password")
## After Fix - Add Spark Connection
## After Fix - Edit Spark Conneciton
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
