jhtimmins commented on a change in pull request #8681:
URL: https://github.com/apache/airflow/pull/8681#discussion_r419530061
##########
File path: airflow/www/views.py
##########
@@ -2627,6 +2627,9 @@ class TaskInstanceModelView(AirflowModelView):
'unixname', 'priority_weight', 'queue', 'queued_dttm',
'try_number',
'pool', 'log_url']
+ # this is to remove the sorting option on these columns that raise
`property has no attribute asc`
+ order_columns = [item for item in list_columns.copy() if item not in
['try_number', 'log_url']]
Review comment:
I think this can do w/out the comment, since `order_columns` has a
specific meaning/purpose in Flask AppBuilder. Otherwise this looks good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
