Acehaidrey commented on a change in pull request #8680:
URL: https://github.com/apache/airflow/pull/8680#discussion_r420502117
##########
File path: airflow/models/taskinstance.py
##########
@@ -1080,6 +1081,8 @@ def signal_handler(signum, frame):
self.handle_failure(e, test_mode, context)
raise
+ Stats.incr('ti.complete.{}.{}.{}'.format(task.dag_id, task.task_id,
self.state), 1, 1)
Review comment:
change it to finished . and moved to a finally so it is better this way
I do the separation on the `.` because can do different grouping aggregates
on statsd/prometheus side vs using the `_`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
