[
https://issues.apache.org/jira/browse/AIRFLOW-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100842#comment-17100842
]
ASF GitHub Bot commented on AIRFLOW-4549:
-----------------------------------------
TeddyHartanto commented on a change in pull request #7735:
URL: https://github.com/apache/airflow/pull/7735#discussion_r420829036
##########
File path: tests/models/test_taskinstance.py
##########
@@ -855,6 +855,25 @@ def test_check_task_dependencies(self, trigger_rule,
successes, skipped,
self.assertEqual(completed, expect_completed)
self.assertEqual(ti.state, expect_state)
+ @parameterized.expand([
Review comment:
Ah good point there. I somehow reasoned this wasn't necessary. I
couldn't quite remember what the exact reason was. But it could be a
misjudgement because now that I take a second look at it, I think we should add
it in. Thanks for catching that!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> wait_for_downstream does not respect skipped tasks
> --------------------------------------------------
>
> Key: AIRFLOW-4549
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4549
> Project: Apache Airflow
> Issue Type: Bug
> Components: scheduler
> Reporter: Dima Kamalov
> Assignee: Teddy Hartanto
> Priority: Major
>
> See
> [http://mail-archives.apache.org/mod_mbox/airflow-dev/201609.mbox/%3ccaheep7utgpjvkgww9_9n5fupnu+pskf3rmbvxugk5dxb6bh...@mail.gmail.com%3E]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
