TeddyHartanto commented on a change in pull request #7735:
URL: https://github.com/apache/airflow/pull/7735#discussion_r421209778
##########
File path: tests/dags/test_issue_1225.py
##########
@@ -47,12 +47,7 @@ def fail():
dag=dag1,
pool='test_backfill_pooled_task_pool',)
-# DAG tests depends_on_past dependencies
-dag2 = DAG(dag_id='test_depends_on_past', default_args=default_args)
-dag2_task1 = DummyOperator(
- task_id='test_dop_task',
- dag=dag2,
- depends_on_past=True,)
+# dag2 has been moved to test_past_dagrun_deps.py
Review comment:
Because `tests/dags/test_issue_1225.py` isn't descriptive. I think it's
clearer if we move it to `tests/dags/test_past_dagrun_deps.py`, which houses
the DAGs with `depends_on_past=True`, and `wait_for_downstream=True`. OA did
the same thing and I agree.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
