ashb commented on a change in pull request #8764:
URL: https://github.com/apache/airflow/pull/8764#discussion_r421470122
##########
File path: airflow/www_rbac/views.py
##########
@@ -564,7 +568,8 @@ def dag_details(self, session=None):
dag_id = request.args.get('dag_id')
dag_orm = DagModel.get_dagmodel(dag_id, session=session)
# FIXME: items needed for this view should move to the database
- dag = dag_orm.get_dag(STORE_SERIALIZED_DAGS)
+ dag = dag_orm.get_dag(
+ conf.getboolean('core', 'store_serialized_dags', fallback=False))
Review comment:
No. This does not make sense.
Thsi change just makes it slower. STORE_SERIALIZED_DAGS is
`conf.getboolean('core', 'store_serialized_dags', fallback=False))`, but
without calling the slow conf.getboolean every time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
