[
https://issues.apache.org/jira/browse/AIRFLOW-5873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102812#comment-17102812
]
ASF GitHub Bot commented on AIRFLOW-5873:
-----------------------------------------
ddelange commented on a change in pull request #6523:
URL: https://github.com/apache/airflow/pull/6523#discussion_r422295222
##########
File path: airflow/contrib/operators/kubernetes_pod_operator.py
##########
@@ -158,17 +167,17 @@ def execute(self, context):
raise AirflowException(
'Pod returned a failure: {state}'.format(state=final_state)
)
- if self.xcom_push:
+ if self.do_xcom_push:
return result
except AirflowException as ex:
raise AirflowException('Pod Launching failed:
{error}'.format(error=ex))
def _set_resources(self, resources):
- inputResource = Resources()
- if resources:
- for item in resources.keys():
- setattr(inputResource, item, resources[item])
- return inputResource
+ return Resources(**resources) if resources else Resources()
+
+ def _set_name(self, name):
+ validate_key(name, max_length=63)
Review comment:
Interesting that it's a breaking change, I was in the understanding that
it would fail downstream and hence was a good check to move upstream to point
of DAG creation. If this causes errors that didn't occur before, maybe it
should be loosened (what do you say @potiuk) and for sure mentioned in
UPDATING.md.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> KubernetesPodOperator fixes and test
> ------------------------------------
>
> Key: AIRFLOW-5873
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5873
> Project: Apache Airflow
> Issue Type: Bug
> Components: operators
> Affects Versions: 1.10.6
> Reporter: David de L.
> Assignee: David de L.
> Priority: Major
> Fix For: 1.10.7
>
>
> There are two PR's for this task, one targeted at v1-10-test branch, and one
> adapted to master branch.
> * `KubernetesPodOperator` kwarg `resources` is erroneously passed to
> `base_operator`, instead should only go to `PodGenerator`. The two have
> different syntax. (both on `master` and `v1-10-test` branches)
> * `resources` passed to PodGenerator [should be
> `k8s.V1ResourceRequirements`]([https://github.com/kubernetes-client/python/blob/3739db034d34b035bc8141740e9073c84ab192c0/kubernetes/client/models/v1_container.py#L45]),
> which is now handled in `KubernetesPodOperator`
> * `kubernetes/pod.py`: `Resources` does not have `__slots__` so accepts
> arbitrary values in `setattr` (not present on either branch
> https://github.com/apache/airflow/blame/50343040ff4679e32e01f138ead80bc4bcef4b47/airflow/contrib/operators/kubernetes_pod_operator.py#L166-L171)
> * `v1-10-test` is behind `master` with KubernetesPodOperator fixes and
> refactors
> ** e.g. move kubernetes folder one level up from `/contrib`
> [https://github.com/apache/airflow/blame/4dd24a2c595d4042ffe745aed947eaaea6abb652/airflow/contrib/operators/kubernetes_pod_operator.py#L21]
> ** fix `xcom_push` to `do_xcom_push`
> [https://github.com/apache/airflow/blame/4dd24a2c595d4042ffe745aed947eaaea6abb652/airflow/contrib/operators/kubernetes_pod_operator.py#L90]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
