ddelange commented on a change in pull request #6523:
URL: https://github.com/apache/airflow/pull/6523#discussion_r422295222
##########
File path: airflow/contrib/operators/kubernetes_pod_operator.py
##########
@@ -158,17 +167,17 @@ def execute(self, context):
raise AirflowException(
'Pod returned a failure: {state}'.format(state=final_state)
)
- if self.xcom_push:
+ if self.do_xcom_push:
return result
except AirflowException as ex:
raise AirflowException('Pod Launching failed:
{error}'.format(error=ex))
def _set_resources(self, resources):
- inputResource = Resources()
- if resources:
- for item in resources.keys():
- setattr(inputResource, item, resources[item])
- return inputResource
+ return Resources(**resources) if resources else Resources()
+
+ def _set_name(self, name):
+ validate_key(name, max_length=63)
Review comment:
Interesting that it's a breaking change, I was in the understanding that
it would fail downstream and hence was a good check to move upstream to point
of DAG creation. If this causes reproducible errors (do you have a MWE @dsaiztc
with a breaking change?) that didn't occur before, it should either be loosened
and for sure mentioned in UPDATING.md, or fixed to incorporate the 9
characters as mentioned above. What do you say @potiuk?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
