ashb commented on a change in pull request #8772:
URL: https://github.com/apache/airflow/pull/8772#discussion_r422534178



##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -648,6 +683,23 @@ def test_dag_serialized_fields_with_schema(self):
         dag_params: set = set(dag_schema.keys()) - ignored_keys
         self.assertEqual(set(DAG.get_serialized_fields()), dag_params)
 
+    def test_operator_subclass_changing_base_defaults(self):

Review comment:
       @kaxil this is the case that means we need to check the MRO for defaults.
   
   I think storing all non-defaults is nicer anyway - we can show these in the 
UI that way




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to