turbaszek commented on a change in pull request #8805:
URL: https://github.com/apache/airflow/pull/8805#discussion_r422637578
##########
File path: airflow/models/baseoperator.py
##########
@@ -634,6 +651,33 @@ def deps(self) -> Set[BaseTIDep]:
NotPreviouslySkippedDep(),
}
+ def _set_xcomargs_dependencies(self) -> None:
+ """
+ Resolves upstream dependencies of a task. In this way passing an
``XComArg`
+ as value for a template field will result in creating upstream
relation between
+ two tasks.
+
+ **Example**: ::
+
+ with DAG(...):
+ generate_content =
GenerateContentOperator(task_id="generate_content")
+ send_email = EmailOperator(...,
html_content=generate_content.output)
+
+ # This is equivalent to
+ with DAG(...):
+ generate_content =
GenerateContentOperator(task_id="generate_content")
+ send_email = EmailOperator(
+ ..., html_content="{{
task_instance.xcom_pull('generate_content') }}"
+ )
+ generate_content >> send_email
+
+ """
+ from airflow.models.xcom_arg import XComArg
+ for field in self.template_fields:
+ arg = getattr(self, field)
+ if isinstance(arg, XComArg):
+ self.set_upstream(arg.operator)
Review comment:
> what about pythonOperator?
What do you mean here @evgenyshulman ?
> usually, template fields are traversed with `operator.render_template`
call, we probably should do the same here
I am not sure if I fully understand you here. What exactly is wrong?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
