mik-laj commented on a change in pull request #8808:
URL: https://github.com/apache/airflow/pull/8808#discussion_r422757468
##########
File path: airflow/providers/google/cloud/operators/cloud_build.py
##########
@@ -83,13 +85,29 @@ def _reformat_storage_source(self):
self.body["source"]["storageSource"] =
self._convert_storage_url_to_dict(source)
+ def _load_body_to_dict(self):
+ """
+ :param file:
+ file path to YAML build config
Review comment:
Can you also add JSON file support? This is not common, but build can
also be defined as JSON files.
> You can write the build config file using the YAML or the JSON syntax.
https://cloud.google.com/cloud-build/docs/build-config#structure_of_a_build_config_file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
