turbaszek commented on a change in pull request #8805:
URL: https://github.com/apache/airflow/pull/8805#discussion_r422861355



##########
File path: airflow/models/baseoperator.py
##########
@@ -672,10 +672,20 @@ def _set_xcomargs_dependencies(self) -> None:
 
         """
         from airflow.models.xcom_arg import XComArg
-        for field in self.template_fields:
-            arg = getattr(self, field)
+
+        def apply_set_upstream(arg: Any):
             if isinstance(arg, XComArg):

Review comment:
       > it can be that something will fail and this feature will become a 
"blocker" to update to the new version
   
   Can you provide an example? We perform an action only when we encounter 
`XComArg` so `self.set_upstream` should work. If it doesn't work then it means 
that our implementation is corrupted.  
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to