pranjalmittal commented on a change in pull request #8644:
URL: https://github.com/apache/airflow/pull/8644#discussion_r424872252
##########
File path: airflow/providers/salesforce/hooks/salesforce.py
##########
@@ -236,6 +236,61 @@ def write_object_to_file(self,
if fmt not in ['csv', 'json', 'ndjson']:
raise ValueError("Format value is not recognized: {}".format(fmt))
+ if filename is None:
+ raise ValueError("Filename cannot be None.")
Review comment:
Added it as an additional check, removed it as the argument is not
optional.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
