turbaszek commented on a change in pull request #8805:
URL: https://github.com/apache/airflow/pull/8805#discussion_r425141185



##########
File path: airflow/models/baseoperator.py
##########
@@ -634,6 +634,43 @@ def deps(self) -> Set[BaseTIDep]:
             NotPreviouslySkippedDep(),
         }
 
+    def set_xcomargs_dependencies(self) -> None:

Review comment:
       Hm, I'm not sure how this should be approached. What I would is :
   ```python
               if isinstance(arg, XComArg):
                   op: BaseOperator = arg.operator
                   self.set_upstream(op)
                   # Picks up any outlets from direct upstream tasks that have 
outlets defined,
                   # as such that if A -> B and B does not have inlets but A 
has outlets, then
                   # these are provided as inlets to B.
                   self.add_inlets(op.get_outlet_defs())
   ```
   However, I am not sure if this is the right approach. Not all outlets of A 
has to be inlets of B. Proposed behaviour is what we get when we use 
`inlets=AUTO` and I'm not sure this is something that should be done auto of 
the box. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to