tanjinP commented on issue #8286:
URL: https://github.com/apache/airflow/issues/8286#issuecomment-629863159
@mik-laj just a few questions and concerns before I dive deeply into this:
1. The Memorystore Redis Hook and Operator have a 'generic' name
(`cloud_memorystore.py`). This new one should probably be specific
(`cloud_memorystore_memcache.py`). Is this okay?
- Once this is complete and implemented, it might be worth going back to
refactor the Redis one to be more specific (suffix with `_redis.py`)
1. It seems like there is an opportunity to have a single hook/abstraction
for both Memorystore options, but they also have different Python client
libraries ([Redis here](https://pypi.org/project/google-cloud-redis/) and
[Memcache here](https://pypi.org/project/google-cloud-memcache/)). They do have
a lot of the same methods, but there are a few differences. So that leads to me
conclude they should have their own hooks (keep existing one for Redis and make
a new one for Memcache) at least until the libraries mature some more. At this
time the Memcache feature is still in beta. What do you think?
1. I have gone through the [Google
documentation](https://docs.google.com/document/d/1_rTdJSLCt0eyrAylmmgYc3yZr-_h51fVlnvMmWqhCkY/edit#heading=h.3sxddzjr5f6q)
and will use #5957 as a guide for the approach. I plan to do some small
cleanups like consistent docstrings if the opportunity is there. Let me know if
that is fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
