kaxil commented on a change in pull request #8898:
URL: https://github.com/apache/airflow/pull/8898#discussion_r427186700
##########
File path: breeze
##########
@@ -1629,9 +1647,13 @@ function flag_push_docker_images() {
# Prints flags that control version of generated packages
function flag_version_suffix() {
echo "
--S, --version-suffix
- Adds optional suffix to the generated backport package version. It can
be used to generate
- rc1/rc2 ... versions of the packages.
+-S, --version-suffix-for-pypi
+ Adds optional suffix to the version in the generated backport package.
It can be used
+ to generate rc1/rc2 ... versions of the packages to be uploaded to
PyPI.
Review comment:
We need to change the version.py file before we upload it to PyPI to
include rcX.
Do we already do that somewhere ?
##########
File path: backport_packages/setup_backport_packages.py
##########
@@ -1074,19 +1103,32 @@ def update_release_notes_for_packages(package_ids:
List[str], release_version: s
import_all_classes(package_ids)
make_sure_remote_apache_exists()
if len(package_ids) == 0:
- package_ids = list(PROVIDERS_REQUIREMENTS.keys())
+ package_ids = get_all_backportable_providers()
for package in package_ids:
update_release_notes_for_package(package, release_version)
+def get_all_backportable_providers() -> List[str]:
+ """
+ Returns all providers that should be taken into account when preparing
backports.
+ For now remove cncf.kubernetes as it has no chances to work with current
core of Airflow 2.0
+ :return: list of providers that are considered for backport packages
+ """
+ # TODO: Maybe we should fix it and release cnncf.kubernetes separately
Review comment:
```suggestion
# TODO: Maybe we should fix it and release cncf.kubernetes separately
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
