chrismclennon commented on a change in pull request #8734:
URL: https://github.com/apache/airflow/pull/8734#discussion_r427191009
##########
File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py
##########
@@ -177,6 +181,7 @@ def __init__(self, # pylint:
disable=too-many-arguments,too-many-locals
full_pod_spec: Optional[k8s.V1Pod] = None,
init_containers: Optional[List[k8s.V1Container]] = None,
log_events_on_failure: bool = False,
+ log_container_statuses_on_failure: bool = False,
Review comment:
In my opinion having both `log_events_on_failure` and
`log_container_statuses_on_failure` be True makes more sense to me since
printing out a few extra logs is close to zero cost and doesn't add that much
clutter. While it looks like it's set to False to be aligned with the precedent
set in code, I'm in favor of switching both to True.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
