mik-laj commented on a change in pull request #8858:
URL: https://github.com/apache/airflow/pull/8858#discussion_r427470645
##########
File path: airflow/providers/google/cloud/operators/bigquery.py
##########
@@ -1222,22 +1265,21 @@ class BigQueryGetDatasetTablesOperator(BaseOperator):
For this to work, the service account making the request must have
domain-wide
delegation enabled.
:type delegate_to: str
-
- :rtype: dict
- .. seealso::
https://cloud.google.com/bigquery/docs/reference/rest/v2/tables/list#response-body
"""
template_fields = ('dataset_id', 'project_id')
ui_color = BigQueryUIColors.DATASET.value
@apply_defaults
- def __init__(self,
- dataset_id: str,
- project_id: Optional[str] = None,
- max_results: Optional[int] = None,
- page_token: Optional[str] = None,
- gcp_conn_id: Optional[str] = 'google_cloud_default',
- delegate_to: Optional[str] = None,
- *args, **kwargs) -> None:
+ def __init__(
+ self,
+ dataset_id: str,
+ project_id: Optional[str] = None,
+ max_results: Optional[int] = None,
+ page_token: Optional[str] = None,
Review comment:
I am surprised by this parameter. I don't think the operator user should
provide it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
